DeployTo setting supported as environment variable #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables the use of environment variables for the DeployTo setting in GitHub environments. The key changes include:
- Adding new workflow inputs (environmentName and environmentDeployToVariableValue) in multiple YAML workflow files.
- Updating the ReadSettings action to pass the new inputs to the underlying PowerShell script.
- Extending the existing workflows to support external configuration through environment variables.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Templates/Per Tenant Extension/.github/workflows/PublishToEnvironment.yaml | Added environment variable parameters to support DeployTo settings |
| Templates/Per Tenant Extension/.github/workflows/CICD.yaml | Added environment variable parameters to support DeployTo settings |
| Templates/AppSource App/.github/workflows/CICD.yaml | Added environment variable parameters to support DeployTo settings |
| Actions/ReadSettings/action.yaml | Updated action inputs and run command to handle new environment variable settings |
Files not reviewed (3)
- Actions/AL-Go-Helper.ps1: Language not supported
- Actions/ReadSettings/ReadSettings.ps1: Language not supported
- Templates/AppSource App/.github/workflows/PublishToEnvironment.yaml: Language not supported
Comments suppressed due to low confidence (4)
Templates/Per Tenant Extension/.github/workflows/PublishToEnvironment.yaml:149
- [nitpick] Consider renaming 'environmentDeployToVariableValue' to a more concise name (e.g., 'deployToVar') to improve clarity and reduce verbosity.
environmentDeployToVariableValue: ${{ vars.DeployTo }}
Templates/Per Tenant Extension/.github/workflows/CICD.yaml:287
- [nitpick] Consider adopting a shorter name for 'environmentDeployToVariableValue' for consistency and better readability across workflow files.
environmentDeployToVariableValue: ${{ vars.DeployTo }}
Templates/AppSource App/.github/workflows/CICD.yaml:273
- [nitpick] Consider using a shorter, more concise name for 'environmentDeployToVariableValue' for improved maintainability and consistency.
environmentDeployToVariableValue: ${{ vars.DeployTo }}
Actions/ReadSettings/action.yaml:24
- [nitpick] Consider renaming the 'environmentDeployToVariableValue' input to a shorter name (e.g., 'deployToVar') to enhance clarity and consistency with other workflow files.
environmentDeployToVariableValue:
freddydk
previously requested changes
May 5, 2025
…entEnvironment action.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Actions/DetermineDeploymentEnvironments/DetermineDeploymentEnvironments.ps1
Fixed
Show fixed
Hide fixed
Actions/DetermineDeploymentEnvironments/DetermineDeploymentEnvironments.ps1
Fixed
Show fixed
Hide fixed
Actions/DetermineDeploymentEnvironments/DetermineDeploymentEnvironments.ps1
Fixed
Show fixed
Hide fixed
mazhelez
reviewed
Jul 9, 2025
mazhelez
approved these changes
Jul 22, 2025
ankosiorek
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is now possible to define your DeployTo setting as an environment variable in your GitHub environments.